Skip to content

additional properties in target-metadata #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

additional properties in target-metadata #127

wants to merge 6 commits into from

Conversation

LucieContamin
Copy link

Allow additional properties in target-metadata section in tasks.json

Fix #126

I was not sure what was the best way to publish this update so I did a new version, let me know if any issues or questions!

@LucieContamin
Copy link
Author

Only change is "additionalProperties": true, on line 1255

@annakrystalli
Copy link
Member

This all needs to be tested against hubAdmin so please do not merge anything until that's done.

Also the version should be v5.1.0 as we're introducing a new feature, not just a hotfix.

@LucieContamin
Copy link
Author

Thank you for the feedback, I changed the version, and will keep it open until it's all tested!

@LucieContamin
Copy link
Author

I tagged here the related issues to make it easier to follow:

@zkamvar
Copy link
Contributor

zkamvar commented May 21, 2025

/diff

@github-actions GitHub Actions
Copy link

Here are your diffs for this pull request

admin-schema.json

--- v5.0.0/admin-schema.json	2025-05-21 16:59:05.892342545 +0000
+++ v5.1.0/admin-schema.json	2025-05-21 16:59:07.304400505 +0000
@@ -1,6 +1,6 @@
 {
     "$schema": "https://json-schema.org/draft/2020-12/schema",
-    "$id": "https://raw.githubusercontent.com/hubverse-org/schemas/main/v5.0.0/admin-schema.json",
+    "$id": "https://raw.githubusercontent.com/hubverse-org/schemas/main/v5.1.0/admin-schema.json",
     "title": "Schema for Modeling Hub administrative settings",
     "description": "This JSON file provides a schema for modeling hub administrative information.",
     "type": "object",

tasks-schema.json

--- v5.0.0/tasks-schema.json	2025-05-21 16:59:05.892342545 +0000
+++ v5.1.0/tasks-schema.json	2025-05-21 16:59:07.304400505 +0000
@@ -1,6 +1,6 @@
 {
     "$schema": "https://json-schema.org/draft/2020-12/schema",
-    "$id": "https://raw.githubusercontent.com/hubverse-org/schemas/main/v5.0.0/tasks-schema.json",
+    "$id": "https://raw.githubusercontent.com/hubverse-org/schemas/main/v5.1.0/tasks-schema.json",
     "title": "Schema for Modeling Hub model task definitions",
     "description": "This is the schema of the tasks.json configuration file that defines the tasks within a modeling hub.",
     "type": "object",
@@ -1252,7 +1252,7 @@
                                             "target_keys",
                                             "is_step_ahead"
                                         ],
-                                        "additionalProperties": false,
+                                        "additionalProperties": true,
                                         "if": {
                                             "properties": {
                                                 "is_step_ahead": {

@zkamvar
Copy link
Contributor

zkamvar commented May 21, 2025

Note that hubverse-org/hubUtils#232 also tracks this PR

@micokoch micokoch removed the request for review from zkamvar May 27, 2025 20:13
@LucieContamin LucieContamin deleted the lc/target_metadata-properties/126 branch May 28, 2025 20:00
@LucieContamin LucieContamin restored the lc/target_metadata-properties/126 branch May 28, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annakrystalli annakrystalli Awaiting requested review from annakrystalli

Assignees
No one assigned
Labels
None yet
Projects
hubverse Development overview
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow additional Properties in target metadata section of the tasks schema
3 participants
@LucieContamin @annakrystalli @zkamvar